Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme-lsp crashes the latest gopls #16

Closed
mariusae opened this issue Sep 10, 2019 · 2 comments
Closed

acme-lsp crashes the latest gopls #16

mariusae opened this issue Sep 10, 2019 · 2 comments

Comments

@mariusae
Copy link

I've filed an issue in the the golang tracker with details. For now, recommend using gopls at hte prior commit:

$ GO111MODULE=on go get golang.org/x/tools/cmd/gopls@238129aa638afb6cf8cf56a290487ddd93c2fad7
@fhs
Copy link
Collaborator

fhs commented Sep 10, 2019

What version of acme-lsp are you using? I recommend the latest tagged release (v0.6.1). master might be unstable right now because I'm making some big changes.

@mariusae
Copy link
Author

I'm using @latest. I'll try with with a tagged release. fwiw, from the golang issue:

Looks like acme-lsp is sending a didopen call before initialized, which it is not allowed to do.
We would have survived that before, although there would have been subtle bugs.
There is still a bug we should fix here (crashes are never ok) but if I am right then the fix is to start obeying the spec and rejecting all messages before the initialize handshake is done, in which case acme-lsp is still going to be broken until that is fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants