Also support single location in Implementation/TypeDefinition/Definition response #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhs
requested changes
Nov 28, 2021
There was a problem hiding this comment.
Thanks.
I'm slightly worried about making changes to auto-generated code (tsserver.go), but I think we need a better solution than coping from gopls. There is some discussion upstream here: microsoft/language-server-protocol#67
tw4452852
force-pushed
the
locations
branch
2 times, most recently
from
4acb4c1
to
580e150
Compare
…ion response Signed-off-by: Tw <wei.tan@intel.com>
fhs
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the LSP 3.16 spec, in following responses, both
Locationand[]Locationare allowed:BTW, I encountered this issue when using Zig's language server (zls).
Signed-off-by: Tw wei.tan@intel.com