Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite 3 support #147

Closed
3 tasks done
Artur- opened this issue Jun 29, 2022 · 1 comment
Closed
3 tasks done

Vite 3 support #147

Artur- opened this issue Jun 29, 2022 · 1 comment

Comments

@Artur-
Copy link

Artur- commented Jun 29, 2022

Is your feature request related to a problem? Please describe.

This plugin seems to work with Vite 3 but installing it is a bit of a hassle as it has

  "peerDependencies": {
    "vite": "^2.0.0"
  },

As a result npm install complains that

npm ERR! Found: vite@3.0.0-beta.4
npm ERR! node_modules/vite
npm ERR!   dev vite@"v3.0.0-beta.4" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^2.0.0" from vite-plugin-checker@0.4.5
npm ERR! node_modules/vite-plugin-checker
npm ERR!   dev vite-plugin-checker@"0.4.5" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Describe the solution you'd like

Expand the peer dependency to cover Vite 3 and pre-releases of Vite 3

Describe alternatives you've considered

Other possibilities would be

  1. Remove the peer dependency
  2. Create a new version of the plugin only for Vite 3

Not sure which one is preferable here

Additional context

No response

Validations

  • Read the docs.
  • Read the Contributing Guidelines.
  • Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.
@fi3ework
Copy link
Owner

I'll test does the plugin works fine with Vite3 out of the box tomorrow. If it works fine, I'll add ^3 support and release a patch version quickly.

@fi3ework fi3ework reopened this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants