Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Stylelint basic support #158

Merged
merged 4 commits into from
Oct 13, 2022
Merged

feat: add Stylelint basic support #158

merged 4 commits into from
Oct 13, 2022

Conversation

ModyQyW
Copy link
Contributor

@ModyQyW ModyQyW commented Jul 24, 2022

#57

Mostly based on the eslint checker.

Tell me if I missed anything. Thanks. :D

@netlify
Copy link

netlify bot commented Jul 24, 2022

Deploy Preview for vite-plugin-checker canceled.

Name Link
🔨 Latest commit 10438b5
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/63479d855ba3f7000741a137

@ModyQyW ModyQyW marked this pull request as ready for review July 25, 2022 06:21
@fi3ework
Copy link
Owner

fi3ework commented Aug 6, 2022

Thanks! great work. The code LGTM mostly although we need to add test case afterwards. We need to add colorMap of diagnostic in the UI of stylelint here.

TypeScript: '#3178c6',
ESLint: '#7b7fe3',
VLS: '#64b587',
'vue-tsc': '#64b587',

@ModyQyW
Copy link
Contributor Author

ModyQyW commented Aug 7, 2022

Thanks for pointing out!

I just update some docs and update checkerColorMap. I use #ffffff (white) as stylelint color, since stylelint's icon includes only black and white and black is not clear enough.

@ModyQyW ModyQyW closed this Aug 29, 2022
@ModyQyW ModyQyW reopened this Aug 29, 2022
@ModyQyW
Copy link
Contributor Author

ModyQyW commented Aug 29, 2022

Just merged main branch and do some updates.

@amstiel
Copy link

amstiel commented Oct 4, 2022

Any updates? Can't wait to see this feature implemented 😃

@ModyQyW ModyQyW closed this Oct 9, 2022
@ModyQyW
Copy link
Contributor Author

ModyQyW commented Oct 9, 2022

Just merged main branch.

@ModyQyW ModyQyW reopened this Oct 9, 2022
@ModyQyW ModyQyW requested a review from fi3ework October 10, 2022 00:35
@fi3ework
Copy link
Owner

LGTM, still needs to resolve a conflict due to the update of package.json yesterday, and it can be merged.

@ModyQyW
Copy link
Contributor Author

ModyQyW commented Oct 10, 2022

It is ready to be merged.

image

@fi3ework
Copy link
Owner

Weird, I can't click merge button on the website and still got a conflict hint 🤔
image

I think the reason is the commits are separated in the commit history that can't be rebased by GitHub. Some squash or cherry-pick might be required.

image

@ModyQyW
Copy link
Contributor Author

ModyQyW commented Oct 13, 2022

Try to do a rebase just now.

@ModyQyW ModyQyW requested a review from fi3ework October 13, 2022 05:10
@fi3ework fi3ework merged commit 333ba13 into fi3ework:main Oct 13, 2022
@fi3ework
Copy link
Owner

Thanks, great work!

@ModyQyW
Copy link
Contributor Author

ModyQyW commented Oct 14, 2022

❤️

@fi3ework fi3ework linked an issue Jan 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stylelint support
3 participants