Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running ESLint on ignored files #162

Merged

Conversation

kylewlacy
Copy link
Contributor

I started configuring vite-plugin-checker for one of my projects today, and I ran into the same issue described in #115. I'm not entirely clear why that issue was closed, as it seemed to me that vite-plugin-checker was still trying to lint ignored files, even in the latest release.

This PR updates the ESLint checker to resolve #115 more directly. Now, when a file changes, the plugin calls eslint.isPathIgnored to see if the file has been ignored in the ESLint config. This should avoid the warning.

@netlify
Copy link

netlify bot commented Aug 10, 2022

Deploy Preview for vite-plugin-checker canceled.

Name Link
🔨 Latest commit 30d849d
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/6313b831e3e0e300087b1012

@Scanerrr
Copy link

@kylewlacy will it fix this issue?
WARNING(ESLint) File ignored because of a matching ignore pattern. Use "--no-ignore" to override. (undefined)

@kylewlacy
Copy link
Contributor Author

@Scanerrr Yes, it should fix that warning!

@groundfloorwebb
Copy link

I'd love to see this get merged, nicely done @kylewlacy ! This is causing a lot of noise on my project.

@fi3ework fi3ework merged commit a491be7 into fi3ework:main Sep 4, 2022
@kylewlacy kylewlacy deleted the fix-eslint-warning-on-ignored-files branch September 4, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to slient the ignored file warning
4 participants