Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Pipeline of this repo seems to be broken #264

Open
2 tasks done
jhoermann opened this issue Jul 31, 2023 · 0 comments
Open
2 tasks done

CI Pipeline of this repo seems to be broken #264

jhoermann opened this issue Jul 31, 2023 · 0 comments

Comments

@jhoermann
Copy link
Contributor

Describe the bug

The Pipeline seems to be broken e.g.: https://github.com/fi3ework/vite-plugin-checker/actions/runs/5624436053/job/15241257246?pr=263

I had a look into it:

  • node 18 test is generating a difference in the snapshot
  • node 20: is running into a pnpm error which is resolved in v8.3.1
  • node 16 on MacOS is generating a difference in the snapshot

My suggestion would be:

  • Fix the snapshot test or remove it for node 18, maybe by creating a custom env flag for it
  • Update pnpm to the latest version - I can provide a PR for that @fi3ework
  • Fix the snapshot for MacOS or even consider dropping the test for now

I would also suggest having the pipeline to run through correctly otherwise it would be possible to overlook errors.

Reproduction

Open PR and let the pipeline run.

Expected behavior

Pipeline should run successfully with all tests.

System Info

Not needed.

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant