Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random strings containing import can produce weird replacements [python] #42

Closed
webknjaz opened this issue Oct 5, 2018 · 4 comments
Closed

Random strings containing import can produce weird replacements [python] #42

webknjaz opened this issue Oct 5, 2018 · 4 comments
Labels
python

Comments

@webknjaz
Copy link

webknjaz commented Oct 5, 2018 •
edited

See: https://github.com/pypa/setuptools_scm/blob/master/setup.py#L2

important note

in a docstring turns into

important note:ant●pan class="pl-s">important note:

(which is undesired)

Related issue: #38
@fiatjaf fiatjaf added the python label Oct 5, 2018
@fiatjaf
Copy link
Owner

fiatjaf commented Oct 5, 2018

Oops.

Actually that should only happen if the line starts with import , but there's a bug in the regex I used.

@fiatjaf fiatjaf closed this as completed in 6ea9d8f Oct 5, 2018
@fiatjaf
Copy link
Owner

fiatjaf commented Oct 5, 2018

Fixed for this specific, but the bug still happens if you have a line starting with import .
We could take more stuff into account, but I don't think it is worthwhile.

@webknjaz
Copy link
Author

webknjaz commented Oct 5, 2018

Yeah, it's still there

@fiatjaf
Copy link
Owner

fiatjaf commented Oct 5, 2018 •
edited

Please wait for the next browser release, sir. These browser extension stores are a hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webknjaz @fiatjaf