remove hanging if no connection #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
await untilOpenwould cause to hang if there was an error. This would cause the UI to hang even if other relays were connected, since the await is in a loop.The key to this PR is adding the
rejectOpen(also renamedisOpentoresolveOpenfor clarity), this will keep the hang up. This will more than likely have upstream effects but less severe than the hang, additional handling most likely needed in the client app, but it appears to work for now.Also, I wrapped the
awaitin thetrySendwhich has additional checks for the web socket status.This will also try to reconnect on an interval if previous connection failed.