New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NIP-01] Subscription for Author/Authors redundant #34
Comments
@Kukks do you remember the reason for this? I also have a vague memory of there being a reason, but was checking in my own implementation and used all my reasoning power but couldn't find it. It seems to make absolute sense to drop it. That will make the protocol simpler at no cost. |
OK, I remember now. The Meanwhile, if you want posts from a single pubkey you would use It showed up this way because first I had only the It was good to remember the reason on why this exists, but of course it makes no sense to keep both fields, we can have just |
I'll go ahead and remove the |
The `authors` field is sufficient to represent all queries that `author` could have been used in. See nostr-protocol/nostr#34 for the discussion leading to this removal.
The "author" and "authors" fields in a REQ message are redundant.
Since these fields are ANDed together, if a subscription filter includes author=A, and authors=[B,C], then it will never return any results. If the filter uses author=A, authors=[A,B,C], it is equivalent to only sending the authors field.
Since it never makes sense to use both of these fields at the same time, and "authors" is more general than "author", I suggest dropping the "author" field from REQ altogether.
The text was updated successfully, but these errors were encountered: