Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIP-01] Multiple values for filter conditions #48

Closed
scsibug opened this issue Jan 1, 2022 · 0 comments · Fixed by #49
Closed

[NIP-01] Multiple values for filter conditions #48

scsibug opened this issue Jan 1, 2022 · 0 comments · Fixed by #49

Comments

@scsibug
Copy link
Contributor

scsibug commented Jan 1, 2022

Currently, with only one value allowed in a filter condition for id and kind, subscriptions are unnecessarily large.

A common use case for a client is to request all the profile, metadata, text notes, and deletion events for a set of followed pubkeys. Constructing this subscription for 100 addresses requires repeating the address in a filter for kind: 0, kind: 1, etc., leading to 400 addresses in the `REQ' message.

Allowing ids and kinds to be treated similarly to authors would allow clients to search across multiple event types without unnecessary duplication in the query. This would lead to significant bandwidth savings for clients and relays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant