Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "<id>" to "<subscription id>" in NIP-01 #66

Closed
vinliao opened this issue Jan 28, 2022 · 1 comment
Closed

Change "<id>" to "<subscription id>" in NIP-01 #66

vinliao opened this issue Jan 28, 2022 · 1 comment

Comments

@vinliao
Copy link
Contributor

vinliao commented Jan 28, 2022

In NIP-01, there's a "REQ" message from client to relay, which looks like this: ["REQ", <id>, <filter JSON>...]. The <id> part confused me a bit (took me some time to figure out what it is). I thought it was event id.

I think it would be less confusing if it's renamed to <subscription id> or <subscription string>. Not a critical issue; just a semantic change to make it easier to understand.

@scsibug
Copy link
Contributor

scsibug commented Jan 29, 2022

Agreed, it would be good to disambiguate from the event id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants