Implement skycoin bip44 wallets #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coin_bip44_wallets
…not created wallets
…t README.md file
refs fibercrypto#256 - Add project badges in README.md
…ercrypto/FiberCryptoWallet into stdevHan_t256_add_converalls
olemis
requested changes
Dec 1, 2019
src/ui/CreateLoadWallet.qml
Outdated
| @@ -52,7 +52,7 @@ Item { | |||
| dataModified() | |||
| } | |||
| } | |||
|
|
|||
| @@ -16,6 +16,7 @@ Dialog { | |||
| property alias mode: createLoadWallet.mode | |||
| property alias name: createLoadWallet.name | |||
| property alias seed: createLoadWallet.seed | |||
| //property alias type: comboBoxWalletType.model[comboBoxWalletType.currentIndex].value | |||
| @@ -31,15 +32,15 @@ Dialog { | |||
| if (mode === CreateLoadWallet.Load){ | |||
| scanA = 10 | |||
| } | |||
| walletModel.addWallet(walletManager.createEncryptedWallet(seed, name,textFieldPassword.text , scanA)) | |||
| walletModel.addWallet(walletManager.createEncryptedWallet(seed, name,textFieldPassword.text, comboBoxWalletType.model[comboBoxWalletType.currentIndex].value, scanA)) | |||
There was a problem hiding this comment.
populate combobox from backend
There was a problem hiding this comment.
... by using values returned by core.WalletSet.SupportedWalleTypes()
src/ui/GeneralStackView.qml
Outdated
| @@ -102,12 +102,12 @@ Item { | |||
|
|
|||
| onWalletCreationRequested: { | |||
| stackView.replace(componentGeneralSwipeView) | |||
| walletManager.createUnencryptedWallet(pageCreateLoadWallet.seed, pageCreateLoadWallet.name,0) | |||
| walletManager.createUnencryptedWallet(pageCreateLoadWallet.seed, pageCreateLoadWallet.name, "deterministic" ,0) | |||
There was a problem hiding this comment.
use constant / variable name
src/ui/GeneralStackView.qml
Outdated
| } | ||
|
|
||
| onWalletLoadingRequested:{ | ||
| stackView.replace(componentGeneralSwipeView) | ||
| walletManager.createUnencryptedWallet(pageCreateLoadWallet.seed, pageCreateLoadWallet.name,10) | ||
| walletManager.createUnencryptedWallet(pageCreateLoadWallet.seed, pageCreateLoadWallet.name, "deterministic", 10) |
There was a problem hiding this comment.
use constant / variable name
…eralls Fixes fibercrypto#256 Add converalls
…ment_skycoin_bip44_wallets' into stdevMauricio1802_t148_Implement_skycoin_bip44_wallets
…the type of default wallets
…Acepted event handler
…etAvailableWalletTypes methods
olemis
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148
Changes:
Does this change need to mentioned in CHANGELOG.md?
yes
Requires testing
yes
Comments about testing , should you have some