Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #135: Handle application configuration using QSettings #260

Merged
merged 94 commits into from
Dec 24, 2019
Merged

Fixes #135: Handle application configuration using QSettings #260

merged 94 commits into from
Dec 24, 2019

Conversation

mauricio1802
Copy link
Member

@mauricio1802 mauricio1802 commented Nov 25, 2019 •
edited by olemis
Loading

Fixes #135
Fixes #284

Changes:

  • Change the approach used for the app settings
  • Create a Config system in the backend allowing to plugins to define their own settings in a plugable way
  • QSettings is used for accomplish the persisten over multiple platform
  • Add make test-docker target to run commands inside thereciepe/qt:linux container
  • Run make test-docker on Travis CI since QSettings tests rely on therecipe/qt

Does this change need to mentioned in CHANGELOG.md?
no

Requires testing
yes

mauricio1802 and others added 23 commits October 20, 2019 17:06
@mauricio1802
[config] Create ConfigSection and Option types
22055a6
@mauricio1802
[config] Implement RegisterSection method for ConfigManager type
bdc9084
@mauricio1802
[config] Remove ConfigSection type and Add config.go
9fd5d50
@mauricio1802
[config] Add GetValues method to SectionManager
3ba91c2
@mauricio1802
[config] Change init and LoadWalletEnvs functions to fit with new config
7e79f17
@mauricio1802
[config] Change Option type to allow multiple levels of groups
b6cb899
@mauricio1802
[config] Change SectionManager methods to allow multi level sections
ccbd1ac
@mauricio1802
[config] Fix methods in skycoin plugin to work with config
4c49f53
@mauricio1802
[config] Create multi platform path to use it as default in wallet so…
19c75f1 
…urce
@mauricio1802
Merge branch 'fiberDevelop' into stdevMauricio1802_t135_Handle_applic…
ce13f91 
…ation_configuration_using_QSettings
@mauricio1802
[config] Remove debug lines
7bd5f95
@mauricio1802
[config] Update init function of skycoin package to use new Config ap…
554ca56 
…proach
@mauricio1802
Merge branch 'fiberDevelop' into stdevMauricio1802_t135_Handle_applic…
530fb7d 
…ation_configuration_using_QSettings
@mauricio1802
[plugin] Move creation and register of skycoin plugin to skycoin/main.go
3380e8a
@mauricio1802
[config] Move Register of skycoin plugin to src/coin/skycoin/models/m…
608c4de 
…ain.go
@mauricio1802
Merge commit '608c4de' into stdevMauricio1802_t135_Handle_application…
256c91c 
…_configuration_using_QSettings
@mauricio1802
[plugin] Rewrite LoadWalletEnv function
6ed4c0b
@stdevCrow
Rename the function edit to setValue and add a function `getValue…
5dce51b 
…` to complement it
@stdevCrow
Read the default settings with the new functions implemented in the `…
262a3ee 
…ConfigManager`
@mauricio1802
[config] Add setValue and getValue methods to ConfigManager
49dbc06
@mauricio1802
[config] Fix error spliting path
afcff93
@mauricio1802
[test] Move model test to src/coin/skycoin/models/main_test.go
31a1bc2
@mauricio1802
Merge branch 'fiberDevelop' into stdevMauricio1802_t135_Handle_applic…
4501bf3 
…ation_configuration_using_QSettings
@olemis
Copy link
Contributor

olemis commented Nov 25, 2019

@stdevMauricio1802 is this ready to be merged ?

@olemis olemis added config App configuration stdev wip Work in progress labels Dec 3, 2019
@olemis olemis added this to In progress in FiberCrypto wallet - Iteration 1 via automation Dec 3, 2019
@olemis olemis added this to the 0.27.0 milestone Dec 3, 2019
@stdevMac
[qt] refs fibercrypto#135 Run qtsetup propertly
955539c
@stdevMac
[ci] refs fibercrypto#135 Set travis_wait time to 50 min
95d95f2
@stdevMac
[ci] refs fibercrypto#135 Test uname_s in travis windows
dc7c30a
@stdevMac
[ci] refs fibercrypto#135 just run uname_s in travis windows build
fd1730d
@stdevMac
[ci] refs fibercrypto#135 remove # in choco install make in travis
0476770
@stdevMac
[make][ci] refs fibercrypto#135 Add rule for travis windows installation
a53ef86
@stdevMac
[ci] refs fibercrypto#135 Restore travis and add build on windows dir…
639a802 
…ectly
@stdevMac
[ci] refs fibercrypto#135 Add cache to travis
f0fffaa
@stdevMac
[make][ci] refs fibercrypto#135 set GO111MODULE=off in windows build
33dc1c2
@stdevMac
[ci] remove gzip installation in travis
3a86160
@stdevMac
[make] refs fibercrypto#135 remove | true in qtsetup
d1e4cbf
@stdevMac
[ci] refs fibercrypto#135 Add Appveyor to project
708116c
@stdevMac
[ci] refs fibercrypto#135 mv appveyor.yml .appveyor.yml
210e93d
@stdevMac
Run using bash -c
8fce635
@stdevMac
[ci] refs fibercrypto#135 Add enviroments var to appveyor
fe17c2b
@stdevMac
[ci] Remove qt installation in appveyor
82cfb35
@stdevMac
[ci] run ls c:/qt
372a636
@stdevMac
[ci] refs fibercrypto#135 Use mingw as default shell in appveyor
f40b411
@stdevMac
Set qt_version to 5.13
3bb28fb
@stdevMac
[make] refs fibercrypto#135 set | true in qtsetup
b2829fb
@stdevMac
[ci] refs Install other qt version
4e57b1f
@stdevMac
[ci] refs#135 Using mingw shell from qt installation
f9ff092
@stdevMac
[ci] Install therecipe/qt using -tags=no_envs
301f9bd
@stdevMac
Update vendor
c7f9d78
@stdevMac
[changelog] Add address book
3fe8367
@stdevMac
[ci] refs fibercrypto#135 Remove appveyor scripts
761fcc9
@stdevMac
Merge remote-tracking branch 'simelo/stdevMac_update_vendor_and_chang…
2117f31 
…elog' into stdevMauricio1802_t135_Handle_application_configuration_using_QSettings
@stdevMac
Revert "Merge remote-tracking branch 'simelo/stdevMac_update_vendor_a…
2e68815 
…nd_changelog' into stdevMauricio1802_t135_Handle_application_configuration_using_QSettings"

This reverts commit 2117f31, reversing
changes made to 761fcc9.
@olemis olemis merged commit b3d7f9c into fibercrypto:develop Dec 24, 2019
FiberCrypto wallet - Iteration 1 automation moved this from In progress to Done Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemis olemis olemis requested changes

@stdevCrow stdevCrow stdevCrow approved these changes

Assignees

@mauricio1802 mauricio1802

Labels
config App configuration stdev wip Work in progress
Projects
FiberCrypto wallet - Iteration 1
  
Done
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Custom QT Docker image for testing Handle application configuration using QSettings
5 participants
@mauricio1802 @olemis @stdevCrow @hsequeda @stdevMac