-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #256 Add converalls #261
Fixes #256 Add converalls #261
Conversation
.travis.yml
Outdated
@@ -14,6 +14,8 @@ matrix: | |||
- DEFAULT_ARCH=rpi2 make install-docker-deps | |||
- DEFAULT_ARCH=rpi3 make install-docker-deps | |||
- make install-deps-no-envs | |||
- go get golang.org/x/tools/cmd/cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two lines should be a new target in Makefile
.travis.yml
Outdated
@@ -26,44 +28,56 @@ matrix: | |||
install: | |||
- DEFAULT_ARCH=android make install-docker-deps | |||
- make install-deps-no-envs | |||
- go get golang.org/x/tools/cmd/cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two lines should be a new target in Makefile
.travis.yml
Outdated
- stage: Linux | ||
install: | ||
- make install-docker-deps | ||
- make install-deps-no-envs | ||
- make install-linters | ||
- go get golang.org/x/tools/cmd/cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two lines should be a new target in Makefile
.travis.yml
Outdated
- stage: Windows | ||
os: windows | ||
install: | ||
- choco install make -y | ||
- travis_wait make install-deps-Windows | ||
- make install-linters | ||
- go get golang.org/x/tools/cmd/cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two lines should be a new target in Makefile
.travis.yml
Outdated
- stage: MacOS | ||
os: osx | ||
osx_image: xcode10.2 | ||
install: | ||
- make install-deps | ||
- go get golang.org/x/tools/cmd/cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two lines should be a new target in Makefile
Makefile
Outdated
@@ -199,6 +199,11 @@ test-sky-launch-html-cover: | |||
go test -coverprofile=$(COVERAGEFILE) -timeout 30s github.com/fibercrypto/FiberCryptoWallet/src/coin/skycoin/models | |||
go tool cover -html=$(COVERAGEFILE) -o $(COVERAGEHTML) | |||
|
|||
test-cover-travis: | |||
go test -covermode=count -coverprofile=coverage.out -timeout 30s github.com/fibercrypto/FiberCryptoWallet/src/util |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are more tests , see test
and test-cover
target.
@stdevAntiD2ta @stdevMauricio1802 @stdevMac is there any chance we can improve these numbers ? |
let's create a new issue if this needs be fixed |
Fixes #256
Changes:
README.md
in status the coverageDoes this change need to mentioned in CHANGELOG.md?
no
Requires testing
Requires testing
no