Fixes #295 slow load times #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et and then refresh balance and address async
… set default node to https://node.skycoin.com
…_times' into stdevAntiD2ta_t295_Slow_load_times
…ction when needed
…es' into stdevAntiD2ta_t295_Slow_load_times
olemis
requested changes
Jan 6, 2020
There was a problem hiding this comment.
I'm getting epic failure on OSX after running make run . Error log ends with
goroutine 631 [chan receive]:
net/http.(*persistConn).addTLS(0xc0004086c0, 0xc0006e2000, 0x10, 0x0, 0xc0006e2011, 0x3)
/usr/local/Cellar/go@1.12/1.12.14/libexec/src/net/http/transport.go:1198 +0x1d4
net/http.(*Transport).dialConn(0xc0000f8360, 0x4dfd060, 0xc000026470, 0x0, 0xc000418180, 0x5, 0xc0006e2000, 0x14, 0x0, 0x0, ...)
/usr/local/Cellar/go@1.12/1.12.14/libexec/src/net/http/transport.go:1271 +0x1cde
net/http.(*Transport).getConn.func4(0xc0000f8360, 0x4dfd060, 0xc000026470, 0xc000549140, 0xc00002ec60)
/usr/local/Cellar/go@1.12/1.12.14/libexec/src/net/http/transport.go:1017 +0xa6
created by net/http.(*Transport).getConn
/usr/local/Cellar/go@1.12/1.12.14/libexec/src/net/http/transport.go:1016 +0x455
goroutine 544 [chan receive]:
net/http.(*persistConn).addTLS(0xc0003c86c0, 0xc0009ac800, 0x10, 0x0, 0xc0009ac811, 0x3)
/usr/local/Cellar/go@1.12/1.12.14/libexec/src/net/http/transport.go:1198 +0x1d4
net/http.(*Transport).dialConn(0xc00054bb00, 0x4dfd060, 0xc000026470, 0x0, 0xc000195a40, 0x5, 0xc0009ac800, 0x14, 0x0, 0x0, ...)
/usr/local/Cellar/go@1.12/1.12.14/libexec/src/net/http/transport.go:1271 +0x1cde
net/http.(*Transport).getConn.func4(0xc00054bb00, 0x4dfd060, 0xc000026470, 0xc0000b9f20, 0xc000482ae0)
/usr/local/Cellar/go@1.12/1.12.14/libexec/src/net/http/transport.go:1017 +0xa6
created by net/http.(*Transport).getConn
/usr/local/Cellar/go@1.12/1.12.14/libexec/src/net/http/transport.go:1016 +0x455
rax 0x0
rbx 0x700006f5e000
rcx 0x700006f5d918
rdx 0x0
rdi 0x12103
rsi 0x6
rbp 0x700006f5d950
rsp 0x700006f5d918
r8 0x0
r9 0x0
r10 0x0
r11 0x206
r12 0x12103
r13 0x4
r14 0x6
r15 0x2d
rip 0x7fff60b87e3e
rflags 0x206
cs 0x7
fs 0x0
gs 0x0
QObject::~QObject: Timers cannot be stopped from another thread
make: *** [run] Error 2
... besides , only 2 first wallets at the top get updated and for a small interval of time. It switches back almost immdiately to N/A label . That should not happen |
…es' into stdevAntiD2ta_t295_Slow_load_times
…es' into stdevAntiD2ta_t295_Slow_load_times
…es' into stdevAntiD2ta_t295_Slow_load_times
…urned by GetUnspentOutput before use it
…es' into stdevAntiD2ta_t295_Slow_load_times
…ounded after check that it is not corrupted
…Address method for return an error too
olemis
requested changes
Feb 25, 2020
olemis
approved these changes
Feb 27, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295
Changes:
Does this change need to mentioned in CHANGELOG.md?
no
Requires testing
Requires testing
yes
Comments about testing , should you have some