-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol cleanups #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, we'll have to remember to notify customers that the next version of Studio won't work with their proxies (I'm assuming that if we remove the legacy bindings from TS, Studio won't be able to query old providers even behind a daemon)
@gagbo I explicitly left support for the legacy proxies in place. Only the providers that are bundled with Studio are all on v2 now. |
Description
Now that the remaining legacy providers are converted, we can also get rid of the legacy types from the protocol.
Also cleans up a few annotations that still used the fp-bindgen v2 syntax.
Fixes FP-2705
Checklist
Please make sure all of these are checked before merging. Please leave items
you think are non-applicable in the list, but use strike-through (
~~
) toindicate they don't apply.
[ ] The OpenAPI schema and generated client have been updated.[ ] New models module has been added to API generator script[ ] PR for API is ready and reviewed: (please link)[ ] PR for FPD is ready and reviewed: (please link)Heads-up: I am intentionally delaying the rollout of the new providers to FPD, since that will give us extra time to test how Studio works with FPD instances that still have the old providers.When adding new operation types:
[ ] PR for fiberplane-ot is ready and reviewed: (please link)After merging, please merge related PRs ASAP, so others don't get blocked.