Skip to content

Commit

Permalink
sandbox, bugfix: [internal/typescript]set 'compilerOptions.module' as…
Browse files Browse the repository at this point in the history
… 'CommonJS', to make test/ts_test.ts valid. (#426)
  • Loading branch information
richardo2016 authored and xicilion committed Jun 5, 2018
1 parent f1bb380 commit 0f37b62
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions fibjs/src/sandbox/loaders/ts_loader.cpp
Expand Up @@ -50,9 +50,11 @@ result_t TsLoader::run(SandBox::Context* ctx, Buffer_base* src, exlib::string na
v8::Local<v8::Object> compilerOptions = v8::Object::New(isolate->m_isolate); v8::Local<v8::Object> compilerOptions = v8::Object::New(isolate->m_isolate);


compilerOptions->Set(isolate->NewString("target"), isolate->NewString("ES6")); compilerOptions->Set(isolate->NewString("target"), isolate->NewString("ES6"));
compilerOptions->Set(isolate->NewString("module"), isolate->NewString("CommonJS"));
compilerOptions->Set(isolate->NewString("strict"), v8::BooleanObject::New(isolate->m_isolate, true)); compilerOptions->Set(isolate->NewString("strict"), v8::BooleanObject::New(isolate->m_isolate, true));
compilerOptions->Set(isolate->NewString("diagnostics"), v8::BooleanObject::New(isolate->m_isolate, true)); compilerOptions->Set(isolate->NewString("diagnostics"), v8::BooleanObject::New(isolate->m_isolate, true));
compilerOptions->Set(isolate->NewString("allowJs"), v8::BooleanObject::New(isolate->m_isolate, true)); compilerOptions->Set(isolate->NewString("allowJs"), v8::BooleanObject::New(isolate->m_isolate, true));

// compilerOptions->Set(isolate->NewString("inlineSourceMap"), v8::BooleanObject::New(isolate->m_isolate, true)); // compilerOptions->Set(isolate->NewString("inlineSourceMap"), v8::BooleanObject::New(isolate->m_isolate, true));
// compilerOptions->Set(isolate->NewString("inlineSources"), v8::BooleanObject::New(isolate->m_isolate, true)); // compilerOptions->Set(isolate->NewString("inlineSources"), v8::BooleanObject::New(isolate->m_isolate, true));
// compilerOptions->Set(isolate->NewString("sourceMap"), v8::BooleanObject::New(isolate->m_isolate, true)); // compilerOptions->Set(isolate->NewString("sourceMap"), v8::BooleanObject::New(isolate->m_isolate, true));
Expand Down
2 changes: 2 additions & 0 deletions test/main.js
Expand Up @@ -54,6 +54,8 @@ run("./ws_test.js");
run("./vm_test.js"); run("./vm_test.js");
run("./db_test.js"); run("./db_test.js");
run("./wasm_test.js"); run("./wasm_test.js");
run("./ts_test.js");
run("./ts_test.ts");


if (global.full_test) { if (global.full_test) {
run("./mongo_test.js"); run("./mongo_test.js");
Expand Down

0 comments on commit 0f37b62

Please sign in to comment.