core, refactor: assign the value to p directly in the constructor of …

…obj_ptr to avoid unnecessary initialization that introduces extra load.
fibjs · May 27, 2023 · 1fe90c0 · 1fe90c0
1 parent c246353
commit 1fe90c0
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/fibjs/include/obj_ptr.h b/fibjs/include/obj_ptr.h
@@ -120,35 +120,33 @@ class obj_ptr {
     }
 
     obj_ptr(T* lp)
+        : p(_ref_ptr(lp))
     {
-        operator=(lp);
     }
 
     obj_ptr(const obj_ptr<T>& lp)
+        : p(_ref_ptr((T*)lp))
     {
-        operator=(lp);
     }
 
     template <class Q>
     obj_ptr(const obj_ptr<Q>& lp)
+        : p(_ref_ptr((Q*)lp))
     {
-        operator=(lp);
     }
 
     ~obj_ptr()
     {
-        Release();
+        if (p)
+            p->Unref();
     }
 
     T* operator=(T* lp)
     {
         if (lp == p)
             return lp;
 
-        if (lp != NULL)
-            lp->Ref();
-
-        return _attach(lp);
+        return _attach(_ref_ptr(lp));
     }
 
     T* operator=(const obj_ptr<T>& lp)
@@ -193,6 +191,14 @@ class obj_ptr {
     }
 
 private:
+    T* _ref_ptr(T* lp)
+    {
+        if (lp != NULL)
+            lp->Ref();
+
+        return lp;
+    }
+
     T* _attach(T* p2)
     {
         T* p1 = p.xchg(p2);