Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FireFox (and Chrome?) #18

Closed
FichteFoll opened this issue Jan 27, 2021 · 2 comments
Closed

Support FireFox (and Chrome?) #18

FichteFoll opened this issue Jan 27, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@FichteFoll
Copy link
Owner

FireFox added mpris2 support some time late last year (2020) and I've been using it with playerctl to great success, but the interface does not support the "Position" property, apparently.

ERROR:__main__:Unknown DBusError encountered during tick
Traceback (most recent call last):
  File "/home/fichte/code/discordrp-mpris/discordrp_mpris/__main__.py", line 71, in run
    await self.tick()
  File "/home/fichte/code/discordrp-mpris/discordrp_mpris/__main__.py", line 105, in tick
    await asyncio.gather(
  File "/usr/lib/python3.9/site-packages/ravel.py", line 2951, in get_prop
    reply.expect_return_objects("v")[0][1]
  File "/usr/lib/python3.9/site-packages/dbussy.py", line 4383, in expect_return_objects
    raise DBusError(self.error_name, self.expect_objects("s")[0])
dbussy.DBusError: org.freedesktop.DBus.Error.NotSupported -- /org/mpris/MediaPlayer2.org.mpris.MediaPlayer2.Player Position is not supported

No idea about Chrome since I haven't tested it, but it seems that discord itself offers a player under a 'chromium' suffied bus that defines /org/mpris/MediaPlayer2 but no interfaces (using QDBusViewer). This will need some investigation.

@FichteFoll FichteFoll added the enhancement New feature or request label Jan 27, 2021
@FichteFoll FichteFoll added this to the 0.4.0 milestone Jan 27, 2021
@vpzomtrrfrt
Copy link

relevant firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1659199

Probably should still add support here for sources that don't support Position

@vpzomtrrfrt
Copy link

Even using the plasma integration extension doesn't work since it still tries to access Position from the firefox one sometimes

@FichteFoll FichteFoll modified the milestones: 0.4.0, 0.3.2 Jan 29, 2022
soopyc pushed a commit to soopyc/discordrp-mpris that referenced this issue Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants