Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to configure players with a space in their name #33

Closed
mariuszste opened this issue May 9, 2023 · 3 comments
Closed

Unable to configure players with a space in their name #33

mariuszste opened this issue May 9, 2023 · 3 comments
Labels
question Further information is requested
Milestone

Comments

@mariuszste
Copy link

It seems to be impossible to configure players that have a space in their name since toml doesn't allow spaces in kay names. Or am I just missing something. If there is a way then documenting it would be a good idea

@FichteFoll
Copy link
Owner

TOML requires parts of sections to be quoted if they should contain spaces or dots, i.e.

[player."Spotify with Spaces"]
ignore = true

If you know of an existing player with spaces, I'll add it to the default config as an example, though commented.

@FichteFoll FichteFoll added the question Further information is requested label May 9, 2023
@FichteFoll FichteFoll added this to the 0.4.0 milestone May 9, 2023
FichteFoll added a commit that referenced this issue May 9, 2023
@FichteFoll
Copy link
Owner

With dbeed4f, I have moved all currently known players that I have uploaded icons for into the default configuration, providing sufficient examples for how to configure players with spaces in their name. Due to an implementation detail, players with a . in their name are currently not supported, but I'm not aware of any at the moment.

@mariuszste
Copy link
Author

Weird, I tried that. Well now it works, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants