Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcontinuous installation with private repositories #19
Comments
|
First, that is a beautiful app! Very nice work I got it to install, but you are right. The vignette needs to be updated because you should not put the app in the pkgs argument. I just walked through it again, and that is a bug. It also looks like your github repo is out of sync with the package description file. Github is at 0.0.16, but the app's package is at 0.0.15. I don't think that is the main problem though because it just triggers an installation each time the icon is clicked. I just ran:
And it pulled it down and installed it on my computer in "Documents\AppInventarioNativas\library\AppInventarioNativas." Because the versions are different, it tries to install every time its icon is clicked but it seems to be working. I'll admit. I have not tested Github's private repos as much as I would like because many of my private repos are on Bitbucket. It looks like we need to dig into that a bit more to figure out why it is not installing correctly. |
Thank you very much, Jon! It is part of my master's degree thesis. We are still working on it, but I'm glad you liked it!
Yes, you are right. I forgot to update it there, but that was a update that I did just to test if the app could pull from Github sucessfully. Like you said, I don't think that's the problem. I had that problem before I made that update.
I understand. Are you using devtools to install from github? I tried to install AppInventarioNativas as a package when it was private using In the Oh, I just noticed that tidyr needs to be included in the pkgs argument too. |
|
Jon, another potential bug that I found is that when I manually set the icons and texts for the app launcher, they are used and work as expected, but, the default ones (setup.ico, default.ico, infoafter.txt, infobefore.txt) are created anyway. Furthermore, the app won't compile unless these files exist in the folder. |
|
Good catch. The new icons will be used but the old icons can cause trouble. I'll patch that piece to make sure that the old icons are ignored after the defaults have changed |
|
I made sure the old icons won't cause compile errors and also added a check to verify that the icons and info texts exist. If they don't, these are the warning messages it will produce:
|
|
@sollano I patched the develop branch using Github's auth_token. Can you try installing it:
Then add Thanks! |
Jon, just compiled the app here, and the default icons are no longer produced. It is working fine now!
Jon, unfortunately this did now work for me. The app crashes just after the "Initializing" message. Here's the error log:
I made sure to update the RInno package, and check if the token was working. It seems like some function is still trying to use login information. Thanks! |
|
I just bit the bullet and bought the privilege to create private repos on Github. There was one line that was not working as expected. I think I just fixed it. |
Oh man, sorry for the trouble. I'm still getting an error with the devtools::install_github("ficonsulting/RInno", ref = "develop")
require(RInno)
create_app(
app_name = "AppInventarioNativas",
app_dir = "app_folder",
app_repo_url = "https://github.com/sollano/AppInventarioNativas",
pkgs = c("shiny", "DT", "formattable", "readxl", "plyr", "tidyr","dplyr", "ggplot2", "lazyeval", "ggdendro","ggthemes","xlsx"),
app_icon = "LAB_logo.ico",
setup_icon = "LAB_logo.ico",
publisher = "treelab ufvjm",
pub_url = "http://gorgens.wixsite.com/treelab",
dir_out = "exe_folder",
info_before = "info_before.txt",
info_after = "info_after.txt",
auth_token = [my-token]
)
compile_iss()I can create a token for you to use, if you'd like. |
|
Nope. That was my fault. I forgot to pass the token down to the lower level function calls... Thank you for your persistent and detailed responses! |
Yes, now it's working perfectly! Awesome. Thank you, jon! I'm glad to help. |
|
Great working with you! I'm going to give you a shout out in the package news update ;) |
Hello Jon,
I've created a continuous installation .exe file of an app I'm developing, using a github repository. It worked, and updated successfully. I had to make one change to the vignette code, however. Putting the apps name in the 'pkgs' argument would throw an error. So I moved it to the remotes argument. With that the app installed and launched. The code for creating the app looks like this:
But, If I use the same code to create another .exe , plus the
auth_userandauth_pwarguments using my account credentials, after making that repository private, the app does not run. It throws the error "startup failed with error(s): there is no package called "AppInventarioNativas" ". It does that after loading all the necessary packages.In the error log, I can see that the the app fails when it tries to download from my private repository:
But here's the thing: If I manually install the app on my computer via the main R GUI or RStudio, the .exe updates the app, and launches it normally, but does not add it to apps library folder like it should.
I'll make the repo public again, so you can check it out if you need to. I'm sure I am missing something here.
Thanks again for the great package!