Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thinking on the R_version check #24

Closed
zhengle-advantaseeds opened this issue Sep 21, 2017 · 7 comments
Closed

Thinking on the R_version check #24

zhengle-advantaseeds opened this issue Sep 21, 2017 · 7 comments
Assignees
Projects

Comments

@zhengle-advantaseeds
Copy link

Currently, the .iss script is checking for an exact match of the R_version specified. Would it possible to check the R_version for a set? For example, instead of specifying R_version = '3.4.1', we can specify R_version >= '3.0.0'.

@Dripdrop12
Copy link
Member

Another great idea @zhengle-advantaseeds! I think we could easily support this. I've just got to brush up on string and numeric conversions in Delphi Pascal to make sure the registry query can support this. We could implement it in the "inst/installation/code.iss" file.

@zhengle-advantaseeds
Copy link
Author

Great! Thanks for the very nice package!

@trybik
Copy link
Contributor

trybik commented Dec 6, 2017

I also vote for that.

@Dripdrop12
Copy link
Member

@trybik and @zhengle-advantaseeds. Can you explain some of your thoughts around supporting this? See my response to #34. The challenge with registry queries, is we would have to build all possible registry entries and query them specifically. That build process in Delphi Pascal would be dictated by the string entered in create_app. It is a decent amount of work, so I just want to make sure we discuss it more before developing it.

@trybik
Copy link
Contributor

trybik commented Dec 20, 2017

Here I have no idea what would check for current OS's R version involve, implementation-wise. I will again refer to idea that's given in the R DESCRIPTION file specification:

The ‘Depends’ field can also specify a dependence on a certain version of R — e.g., if the package works only with R version 3.0.0 or later, include ‘R (>= 3.0.0)’ in the ‘Depends’ field.

I think this is quite important because ATM if I wrote an app with most current R version, which was "3.4.1" and the user did not update his R (more frequent case), or has a newer R ver. "3.4.3", then either his OS's R becomes the newer one and he is forced to update all packages (quite annoying), or he just ends up with additional older R installation (much less annoying).

@Dripdrop12 Dripdrop12 moved this from To Do to In progress in RInno Dec 20, 2017
@zhengle-advantaseeds
Copy link
Author

I agreed with @trybik. However, I did look into the Pascal script in the Inno, and it returns strings. Like @Dripdrop12 said, it would be a good amount of workload to implement 'R(>=3.0.0)'. Instead, could we modified the config file? For example,

Step 1: in the RInno, use R_version as the minimum required version: for example, 0.0.5
Step 2: do the string editing in R: to automatically generate all the lower version: 0.0.4, 0.0.3, 0.0.2, 0.0.1.
Step 3: in the Inno, implement a for loop to loop over all the lower version in the registry check.

I am more familiar with R, so I can help with any workloads related to the R.

@Dripdrop12
Copy link
Member

Done :)

RInno automation moved this from In progress to Done Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
RInno
  
Done
Development

No branches or pull requests

3 participants