Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BULK #12

Closed
feedly opened this issue Apr 19, 2010 · 1 comment
Closed

BULK #12

feedly opened this issue Apr 19, 2010 · 1 comment

Comments

@feedly
Copy link

feedly commented Apr 19, 2010

Hello,
Thanks for putting together this redis client. Did some testing today. Ran into a bug where there was no callback when "get"ing a key which had a large value. After some debugging, I noticed that the problem was related to this.valueBufferLen being reset.

See:

    // If the current value buffer is too big, create a new buffer, copy in
    // the old buffer, and replace the old buffer with the new buffer.

    if (this.valueBufferLen === this.valueBuffer.length) {
        sys.puts( ">>>> BUFFER OVERFLOW" );
        var newBuffer = new Buffer(this.valueBuffer.length * 2);
        this.valueBuffer.copy(newBuffer, 0, 0);
        ///D this.valueBufferLen = 0;
        this.valueBuffer = newBuffer;
    }
@fictorial
Copy link
Owner

This was fixed on Saturday. There was a test added for this on Sunday. Check out HEAD.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant