Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

models.py:31-32: Explore Category.specification field... #494

Closed
0pdd opened this issue Mar 11, 2019 · 4 comments
Closed

models.py:31-32: Explore Category.specification field... #494

0pdd opened this issue Mar 11, 2019 · 4 comments
Assignees
@duker33
Labels
2 performer can implement issue at his closest convenient time Tags feature wontpay

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 11, 2019

The puzzle 483-11f026a3 from #483 has to be resolved:

stroyprombeton/stroyprombeton/models.py

Lines 31 to 32 in bc0f7a6

# @todo #483:30m Explore `Category.specification` field purpose.
# Then document or rename it.

The puzzle was created by duker33 on 11-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 11, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Mar 11, 2019
@duker33
#483 #455 Move data from product fields to options and tags (#487)
bc0f7a6 
* #483  Draft for options and tags creation

* #483  Create options and tags

* #455  Rm data fields from Product and Option models

* #483  Review#1 fix. Move custom data migrations to RunPython

* #483  Adapt search to new DB structure

* #483  Review#1. Move product grouping to func, bind tags to options

* #483  Adapt fixtures to the new DB scheme

* #455  Fix tests

* #455  Skip some tests. Create pdd issues for them

* #483  Group products by name+category_id in migrations

* #455  Skip problem test to prevent fatal traceback in output

* #483  Make some operations bulk and atomic

* #483  Add missed pdd issues

* #483  Return back the state of temporary files

* #483  Review#3 fix

* #483  Grade refarm dep to 0.5.0

* #483  Move slug creating logic to migrations

* #483  Tests minor fixes

* #483  Skip several fallen tests
@0pdd 0pdd mentioned this issue Mar 11, 2019
Closed
@duker33 duker33 added 30 mins small issues. Usually cosmetic fixes 2 performer can implement issue at his closest convenient time Tags feature labels Mar 12, 2019
@duker33 duker33 self-assigned this Mar 12, 2019
@duker33 duker33 mentioned this issue Mar 12, 2019
Open
@duker33
Copy link
Contributor

duker33 commented Mar 23, 2019

production db contains only four categories with specification field, that is not the part of name:

Открытый цех по переработке сыпучих навалочных грузов промышленных предприятий. Рабочая документация: ТП 709-9-126.93. Альбом 3 | Рабочая документация: ТП 709-9-126.93 Альбом 3
Колодцы водопроводные. ТПР 901-09-11.84 | ТПР 901-09-11.84
Затопленный водоприёмник раструбный производительностью от 0,02 до 0,3 м3/с. ТП 901-1-60.86 | ТП 901-1-60.86
Колонны железобетонные для открытых крановых эстакад. Серия 3.013.9-1. Выпуск 1 | Рабочая документация: Серия 3.013.9-1. Выпуск 1

@duker33
Copy link
Contributor

duker33 commented Mar 23, 2019

And it's from prod:

> Category.objects.exclude(specification='').filter(children__isnull=False).count()
142

It means that DB contains not leaf categories with not empty specification field

@duker33
Copy link
Contributor

duker33 commented Mar 23, 2019

i'll resolve this field at #510

@duker33 duker33 closed this as completed Mar 23, 2019
@duker33 duker33 added wontpay and removed 30 mins small issues. Usually cosmetic fixes labels Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@duker33 duker33

Labels
2 performer can implement issue at his closest convenient time Tags feature wontpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd