Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spurious newline added when diff contains a list with new elements #100

Closed
t3chguy opened this issue May 14, 2020 · 4 comments
Closed

spurious newline added when diff contains a list with new elements #100

t3chguy opened this issue May 14, 2020 · 4 comments

Comments

@t3chguy
Copy link

t3chguy commented May 14, 2020

See https://jsfiddle.net/3u95j6z0/

When applied, this diff looks like
image

Additionally, this diff could be simplified to just a single step and that would hugely clean it up.
@t3chguy t3chguy mentioned this issue May 14, 2020
Merged
@johanneswilm
Copy link
Member

Hey, the newline that is being added is because there is another textnode with a newline in it. This currently spans over 3 diffs, which could be cut down to 2 under perfect conditions. I think this looks quite acceptable though.

@johanneswilm
Copy link
Member

If you want to investigate it more and write a patch, I'd be happy to merge it @t3chguy .

@johanneswilm
Copy link
Member

@t3chguy I received a message that you commented on this issue, but the comment seems to have disappeared.

@t3chguy
Copy link
Author

t3chguy commented Sep 28, 2020

Yup, I deleted it, it was moot and a bad reproduction case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johanneswilm @t3chguy