Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove outdated DMLT multivariate analysis tutorial #594

Closed
robertoostenveld opened this issue Sep 20, 2022 · 2 comments · Fixed by #595
Closed

remove outdated DMLT multivariate analysis tutorial #594

robertoostenveld opened this issue Sep 20, 2022 · 2 comments · Fixed by #595
Assignees

Comments

@robertoostenveld
Copy link
Contributor

The external DMLT code has not been maintained and It was recently reported through the FT mailing list that the tutorial does not work any more. The original authors have even removed the code that was once upon a time shared on https://github.com/distrep/DMLT.

I don't see the reason why we would keep this tutorial online, and also propose to remove the external/dmlt directory from the fieldtrip toolbox itself.

@schoffelen
Copy link
Contributor

OK, this requires some changes to the website repo, and to the fieldtrip repo

for the website, I suggest to just unlink the tutorial on the tutorial table-of-contents page, and add an even stronger note to the top of the mvpa tutorial page, should anybody still end up there.

for the code repo I will remove the external/dmlt folder, move ft_statistics_crossvalidate to external/obsolete, update de docstrings in ft_timelock/freqstatistics, and adjust the relevant functions in the test-folder.

@robertoostenveld
Copy link
Contributor Author

why not remove it altogether? If we keep it, then a google search might still direct to it. Or people might end up there
by other means. If we don't want people to run that code, I think it is better to make it disappear altogether. People can still look it up (if they really care) in the github history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants