Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordinal quickfix doesn't handle all cases (noted for en_US, en_GB) #37

Closed
jabjab opened this issue Mar 31, 2015 · 1 comment
Closed

Comments

@jabjab
Copy link

jabjab commented Mar 31, 2015

Is the quickfix described in https://github.com/fightbulc/moment.php#iv-fixed-ordinal-representations only for 'WS', or is it supposed to work for other formatting as well?

$result = (new Moment('2015-03-31T20:00:00+0000'))->format('l, dS F Y');

Expected result: Tuesday, 31st March 2015
Actual result: Tuesday, 31rd March 2015

I believe it's recommended to not use ordinals in dates like "March 31, 2015" for en_US, but this still seems like an annoying bug.

@fightbulc
Copy link
Owner

Hey there. Thanks for spotting this. Just pushed a fix and released a new version.

9d580ef

Cheers from Berlin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants