Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Potential Future Issue] Not all field types have a corresponding column type #2

Open
tabacitu opened this issue Jun 30, 2022 · 0 comments

Comments

@tabacitu
Copy link
Collaborator

I noticed this add-on is using fields to also define columns inside the ListOperation. This is probably inspired by Nova, for someone coming from there it should be pretty intuitive, but we should keep in mind that in Backpack fields and columns are separate things, and:

  • there might be inconsistencies in the definition, between a field and a column with the same name;
  • there will definitely be fields without a corresponding field type;

I don't think this is something that package can fix... it's the inconsistency in Backpack that's the problem. But it's something we should be aware of, test and know.

Let me make this clear, though: we do plan to fix this in Backpack: every inconsistency we can fix in a non-breaking way, we'll do in 5.x, everything else in v6. So... by Backpack v6, this should be a non-issue, we'll have fields and columns perfectly aligned. I'd love for @phpfour to be the one that tracks down and solves these inconsistencies. But there's quite a bit of work to be done there, see Laravel-Backpack/community-forum#196 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant