Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage #32

Open
martinfrances107 opened this issue Apr 19, 2021 · 0 comments
Open

Add code coverage #32

martinfrances107 opened this issue Apr 19, 2021 · 0 comments

Comments

@martinfrances107
Copy link
Collaborator

I am measuring my progress in porting this module into rust by the amount to code coverage I see...

That is compared to this module.

It is a simple change to the package.json file have a new test script, So that when I run

npm run coverage

I see this appended to the usual test result.

-------------------|---------|----------|---------|---------|------------------------
File               | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s      
-------------------|---------|----------|---------|---------|------------------------
All files          |   93.85 |    72.02 |   98.75 |   96.39 |                        
 d3-geo-voronoi.js |   93.85 |    72.02 |   98.75 |   96.39 | 31,300-315,474,489,495 
-------------------|---------|----------|---------|---------|------------------------

Its adds a new dependancy 'nyc' but it is a popular module with over a million weekly download
https://www.npmjs.com/package/nyc

I am about to generate a PR.

martinfrances107 added a commit to martinfrances107/d3-geo-voronoi that referenced this issue Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant