Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Can move focus out of modal two #1

Closed
danielmatthew opened this issue Aug 26, 2020 · 3 comments
Closed

Can move focus out of modal two #1

danielmatthew opened this issue Aug 26, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@danielmatthew
Copy link

👋 I feel bad reporting a bug as the first issue, particularly as it's an otherwise neat implementation:

macOS 10.15.6
Safari 13.1.2 (15609.3.5.1.3)

On opening modal two, I was able to set focus on links in the document behind, which I've hoped to capture in the following gif:

2020-08-26 16-35-20 2020-08-26 16_38_09

@tbroyer
Copy link

tbroyer commented Aug 26, 2020

I as about to open an issue about that second modal too, but it is likely the cause of the behavior you reported, so commenting here instead: when opening the second modal, the rest of the page loses its aria-hidden="true" inert attributes.

(Chrome 85.0.4183.83 on Linux)

@scottjehl scottjehl added the bug Something isn't working label Aug 26, 2020
@scottjehl
Copy link
Member

Thanks! Marking this as a bug to fix.

@scottjehl
Copy link
Member

Fixed in master. thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants