Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Facebook button breaks when locale parameter is set #29

Closed
Schepp opened this issue Feb 15, 2013 · 2 comments
Closed

Facebook button breaks when locale parameter is set #29

Schepp opened this issue Feb 15, 2013 · 2 comments

Comments

@idflood
Copy link
Contributor

idflood commented Feb 18, 2013

The locale parameter from facebook use a different format than html. ("BCP47" format vs "ISO language and country codes respectively, concatenated by an underscore")

I didn't saw this issue before creating #32.

I think in your case the parameter should be "de_DE". So relying only with js to convert these format could be problematic (in my case it was fr-FR instead of fr_FR).

So adding an attribute "data-locale" is the best way to be able to fix this issue. Adding a large javascript to handle these cases doesn't look right.

idflood added a commit to idflood/SocialCount that referenced this issue Feb 18, 2013
idflood added a commit to idflood/SocialCount that referenced this issue Feb 18, 2013
idflood added a commit to idflood/SocialCount that referenced this issue Feb 18, 2013
@benoitboucart
Copy link

Thanks Schepp. When I remove the locale I finally see the "like" button :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants