Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelationManager breaking form values when edit #3906

Closed
joaovdiasb opened this issue Sep 8, 2022 · 8 comments
Closed

RelationManager breaking form values when edit #3906

joaovdiasb opened this issue Sep 8, 2022 · 8 comments
Labels
Milestone

Comments

@joaovdiasb
Copy link
Contributor

joaovdiasb commented Sep 8, 2022

Package

filament/tables

Package Version

v2.15.45

Laravel Version

v9.28.0

Livewire Version

v2.10.7

PHP Version

PHP 8.1.9

Problem description

In RelationManager when view some record with RichEditor before edit, throws a error in console and don't show the form values.

CleanShot 2022-09-08 at 09 30 47@2x

Expected behavior

Show form values

Steps to reproduce

1 - Add in RelationManager form the RichEditor

RichEditor::make()

2 - View some RelationManager record with ViewAction

Tables\Actions\ViewAction::make() 

3 - Edit some RelationManager record with EditAction

Tables\Actions\EditAction::make()

Reproduction repository

https://github.com/joaovdiasb/fillament-process

@zepfietje
Copy link
Member

I can't reproduce the issue.

Could you add a seeder and clear steps to reproduce the problem using your reproduction repository?

@joaovdiasb
Copy link
Contributor Author

Video of reproduction https://drive.google.com/file/d/15Sf1EZagEBxkIO2927sa3jlzM461wmyz/view?usp=sharing

already have the data in factory
php artisan migrate:fresh --seed

@nunoxavier
Copy link

nunoxavier commented Oct 17, 2022

@zepfietje I'm currently having similar issues (not entirely related to the RichEditor), you can reproduce it on the current Filament demo
https://demo.filamentphp.com/shop/brands/20/edit?activeRelationManager=0

Steps:

  1. click on one item from the products list, then click outside the modal
  2. click on another item from the products list, you'll see the console error

Thanks in advance

Edit: worth to mention that by submitting the modal's form and then opening a different item will not produce any error

@joaovdiasb
Copy link
Contributor Author

@zepfietje I'm currently having similar issues (not entirely related to the RichEditor), you can reproduce it on the current Filament demo https://demo.filamentphp.com/shop/brands/20/edit?activeRelationManager=0

Steps:

  1. click on one item from the products list, then click outside the modal
  2. click on another item from the products list, you'll see the console error

Thanks in advance

Edit: worth to mention that by submitting the modal's form and then opening a different item will not produce any error

Yes, I've had this problem with Select too, outside the relation manager, normal table.

@danharrin
Copy link
Member

Does #4764 fix this?

@joaovdiasb
Copy link
Contributor Author

joaovdiasb commented Nov 3, 2022

Does #4764 fix this?

still not for what i'm doing

Steps:

  1. View some relation manager
  2. Close
  3. Edit another

@danharrin
Copy link
Member

Please check again in the latest release

@joaovdiasb
Copy link
Contributor Author

Its fixed now, thanks!

Please check again in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants