Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing binding of the QAIM::index() and QAIM::createIndex functions #46

Closed
White-Oak opened this issue Sep 25, 2016 · 6 comments
Closed
Assignees

Comments

@White-Oak
Copy link

White-Oak commented Sep 25, 2016

It's more of a call of help, then an issue:

dataChanged has, among others, two parameters topLeft, bottomRight which are DosQModelIndex. The question is -- how do I get these indexes? By calling dos_qmodelindex_create and then dos_qmodelindex_sibling? I suppose they won't be valid as they are not connected to the model?

Or maybe, there should be a binding for http://doc.qt.io/qt-5/qabstractitemmodel.html#index or http://doc.qt.io/qt-5/qabstractitemmodel.html#createIndex?

@filcuc
Copy link
Owner

filcuc commented Sep 25, 2016

you're right they're missing. I will add them asap.
They were not binded because i usually return a QObject inside the data function a QAIM.
By returning a QObject a the return value of the data() function you don't have to implement the dataChanged. In fact the the QML binds to the property of the QObject (and so they will update when the QObject emit the propertyChanged).
Sorry it was my fault. I will fix.

@filcuc filcuc added the bug label Sep 25, 2016
@filcuc filcuc changed the title Using dataChanged of DosQAbstractListModel Missing binding of the QAIM::index() and QAIM::createIndex functions Sep 25, 2016
@filcuc filcuc self-assigned this Mar 5, 2017
@filcuc
Copy link
Owner

filcuc commented Mar 5, 2017

@White-Oak my branch qaim should have a fix for this if you want to test it. This will break API/ABI since i've to rework QALM. I've exposed all QAIM functions

@White-Oak
Copy link
Author

@filcuc thanks, i'll begin implementing them on my side

@filcuc
Copy link
Owner

filcuc commented Mar 5, 2017

@White-Oak i suggest both of us to keep a separate branch in order to fix bindings and release together. Sound good to you? I don't want to release and break API to existing bindings

@White-Oak
Copy link
Author

@filcuc we've begin using dotherside as a git submodule, so unless we update it, nothing will break :) Release it when you wish 👍

@filcuc
Copy link
Owner

filcuc commented Apr 9, 2017

Fixed in v0.6.0

@filcuc filcuc closed this as completed Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants