Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environmental variable expansion #1241

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

WeidiDeng
Copy link
Contributor

Description
Fix 1211.

🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

❤️ Thank you!

Copy link
Member

@o1egl o1egl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove search related commits from this pr.

runner/runner.go Show resolved Hide resolved
@WeidiDeng WeidiDeng reopened this Jan 13, 2021
@o1egl o1egl merged commit f3afd5c into filebrowser:master Jan 19, 2021
@WeidiDeng
Copy link
Contributor Author

WeidiDeng commented Jan 23, 2021

I found out that there is a global setting called Execute on shell that is supposed to do the envars expansion. Guess that's overlooked.

Also user executed command on the built-shell is affected by that setting too. I think documentation needs to be made more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commands Runner variables
2 participants