Fix 401 error in share view open file button #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This link would be generated with a `?token=<hash>?inline=true` when it should be `?token=<hash>&inline=true`. This was causing 401 Unauthorized errors because `URL.Query().Get("token")` would return the empty string and so (authenticateShareRequest)[https://github.com/filebrowser/filebrowser/blob/dee465ab865ba5bf96fbfbe5888f4e95731d3701/http/public.go#L126] would try to verify the password in the header, which doesn't exist for these requests.
ramiresviana
reviewed
Aug 3, 2021
frontend/src/views/Share.vue
Outdated
| @@ -93,7 +93,7 @@ | |||
| </a> | |||
| <a | |||
| target="_blank" | |||
| :href="link + '?inline=true'" | |||
| :href="link + '&inline=true'" | |||
There was a problem hiding this comment.
This will make the link invalid on shares without password.
There was a problem hiding this comment.
Good point, I really need to properly construct the query string using official builder methods.
This should avoid the pitfalls of trying to manually decide to attach inline=true with a ? or a &.
|
Please make sure that all checks are passing. |
|
You will need to squash your commits, taking into account the commintlint rules. |
Alsan
pushed a commit
to Alsan/filebrowser
that referenced
this pull request
Aug 25, 2021
rahul-r
pushed a commit
to rahul-r/filebrowser
that referenced
this pull request
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This link would be generated with a
?token=<hash>?inline=truewhen it should be?token=<hash>&inline=true. This was causing 401 Unauthorized errors becauseURL.Query().Get("token")would return the empty string and so authenticateShareRequest would try to verify the password in the header, which doesn't exist for these requests.