Mod modified time format #1536
Merged
Mod modified time format #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some people like the current behavior. It must be set as a user config param |
o1egl
reviewed
Sep 8, 2021
| @@ -214,6 +215,7 @@ | |||
| "rules": "Rules", | |||
| "rulesHelp": "Here you can define a set of allow and disallow rules for this specific user. The blocked files won't show up in the listings and they wont be accessible to the user. We support regex and paths relative to the users scope.\n", | |||
| "scope": "Scope", | |||
| "setDateFormat": "Set exact date format", | |||
There was a problem hiding this comment.
Actually, I copy the feture "hit dot files" to implement the issue.
there are two "hit dot files" settings in en.json
I'll commit that
ramiresviana
reviewed
Sep 9, 2021
| @@ -106,6 +106,9 @@ export default { | |||
| return filesize(this.size); | |||
| }, | |||
| humanTime: function () { | |||
| if (this.user.dateFormat) { | |||
| return moment(this.modified).format("YYYY-MM-DD HH:mm"); | |||
There was a problem hiding this comment.
Suggested change
| return moment(this.modified).format("YYYY-MM-DD HH:mm"); | |
| return moment(this.modified).format("L LT"); |
FileBrowser supports multiples languages, dates should be displayed with a localized format.
|
great
Ramires Viana ***@***.***> 于2021年9月9日周四 下午8:30写道：
… ***@***.**** commented on this pull request.
------------------------------
In frontend/src/components/files/ListingItem.vue
<#1536 (comment)>
:
> @@ -106,6 +106,9 @@ export default {
return filesize(this.size);
},
humanTime: function () {
+ if (this.user.dateFormat) {
+ return moment(this.modified).format("YYYY-MM-DD HH:mm");
⬇️ Suggested change
- return moment(this.modified).format("YYYY-MM-DD HH:mm");
+ return moment(this.modified).format("L LT");
FileBrowser supports multiples languages, dates should be displayed with a
localized format.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1536 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVA3DSAKGJZ3DNAZ3ZBE6ZLUBCSFNANCNFSM5DLLPVAQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add setting for exact date format.
Default: previous "from now" format
After setting: display "YYYY-MM-DD HH:mm" format
#1525