make theme_color of Manifest can be set #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'theme_color' of Manifest affects the color of status bar of mobile view, however it's statc before. Make it can be set via `filebrowser config set --branding.color "<hex-color-code>"`. Signed-off-by: bekcpear <i@bitbili.net>
ramiresviana
suggested changes
Sep 8, 2021
There was a problem hiding this comment.
Chrome desktop/mobile ignores the theme-color from dynamic manifest. You have to use template variables on index.html#L19 and index.html#L29.
Thanks @ramiresviana for pointing out the problem: "Chrome desktop/mobile ignores the theme-color from dynamic manifest."
ramiresviana
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'theme_color' of Manifest affects the color of status bar
of mobile view, however it's static before. Make it can be set
via
filebrowser config set --branding.color "<hex-color-code>".Signed-off-by: bekcpear i@bitbili.net