Detect multiple subtitle languages #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiresviana
suggested changes
Dec 20, 2021
Co-authored-by: Ramires Viana <59319979+ramiresviana@users.noreply.github.com>
o1egl
reviewed
Dec 20, 2021
files/file.go
Outdated
| dir, err := afs.ReadDir(parentDir) | ||
| if err == nil { | ||
| base := strings.TrimSuffix(i.Name, ext) | ||
| r := regexp.MustCompile("^" + regexp.QuoteMeta(base) + `\.(.*\.)?vtt$`) |
There was a problem hiding this comment.
MustCompile must not be used for user-provided data. Use Compile instead. I think we can use a simple substring check which would be ~200 times faster than regexp https://go.dev/play/p/HOZBYFaGH1Z
There was a problem hiding this comment.
I agree. This would eliminate the restriction to Base.Lang.vtt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1702 as suggested in this comment.