Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upload file list with progress #1825

Merged
merged 16 commits into from
Feb 21, 2022
Merged

feat: add upload file list with progress #1825

merged 16 commits into from
Feb 21, 2022

Conversation

filippofinke
Copy link
Contributor

Description
Add the list of files that are being uploaded and their relative progress.

Reference to issue #1380

out

@ramiresviana
Copy link
Contributor

While it looks functional, the design is in a rough state and needs improvement. The progress indicator takes up a large part or even all of the screen space, depending on the number of files being uploaded. We need a compact design that doesn't get in the way of users and fits different screen sizes.

@o1egl
Copy link
Member

o1egl commented Feb 15, 2022

I'd suggest something like that one #1380 (comment) . Ideally, this window should be minimized and expanded when the user clicks on it

@filippofinke
Copy link
Contributor Author

filippofinke commented Feb 15, 2022

I'd suggest something like that one #1380 (comment) . Ideally, this window should be minimized and expanded when the user clicks on it

Thank you for the feedback.

I'll work on it as soon as I have time.

@filippofinke
Copy link
Contributor Author

filippofinke commented Feb 15, 2022

@ramiresviana @o1egl

I have updated the design, still some work has to be done.

out

It's giving errors because my server disk is full.

@ramiresviana
Copy link
Contributor

Please make sure that you're using the project ESLint rules, making the style of your code consistent with the current codebase.

When there's a upload in progress, users cannot upload more files since the header action shows only the progress prompt.

@filippofinke
Copy link
Contributor Author

Please make sure that you're using the project ESLint rules, making the style of your code consistent with the current codebase.

When there's a upload in progress, users cannot upload more files since the header action shows only the progress prompt.

I have fixed the code style.

I agree that users can't upload more files because of the progress prompt.

I'll try to create a prompt on the bottom right that doesn't block user navigation and that can be maximized/minimized.

Something like this one:

image

@filippofinke
Copy link
Contributor Author

I am currently working on the icons on the left side of the file name, some other designs improvement and then I'll do some refactoring.

Current status:
out

@filippofinke
Copy link
Contributor Author

Added icons:

image

@o1egl o1egl merged commit cf85404 into filebrowser:master Feb 21, 2022
rahul-r pushed a commit to rahul-r/filebrowser that referenced this pull request Sep 2, 2022
Shada pushed a commit to Shada/filebrowser that referenced this pull request Feb 22, 2023
Shada pushed a commit to Shada/filebrowser that referenced this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants