-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upload file list with progress #1825
Conversation
While it looks functional, the design is in a rough state and needs improvement. The progress indicator takes up a large part or even all of the screen space, depending on the number of files being uploaded. We need a compact design that doesn't get in the way of users and fits different screen sizes. |
I'd suggest something like that one #1380 (comment) . Ideally, this window should be minimized and expanded when the user clicks on it |
Thank you for the feedback. I'll work on it as soon as I have time. |
I have updated the design, still some work has to be done. It's giving errors because my server disk is full. |
Please make sure that you're using the project ESLint rules, making the style of your code consistent with the current codebase. When there's a upload in progress, users cannot upload more files since the header action shows only the progress prompt. |
I have fixed the code style. I agree that users can't upload more files because of the progress prompt. I'll try to create a prompt on the bottom right that doesn't block user navigation and that can be maximized/minimized. Something like this one: |
Description
Add the list of files that are being uploaded and their relative progress.
Reference to issue #1380