Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview media in an overlay to maintain navigation state #1833

Closed
williewillus opened this issue Feb 21, 2022 · 15 comments
Closed

Preview media in an overlay to maintain navigation state #1833

williewillus opened this issue Feb 21, 2022 · 15 comments
Labels

Comments

@williewillus
Copy link

Is your feature request related to a problem? Please describe.
Scenario: User is deep in a browse of a folder with lots of images. They want to open one. Middle click doesn't work to open it in another tab, so they double click to open. Done enjoying the photo, they either hit Back on the browser or the X in the corner, but they go back to a completely blank folder state. All thumbnails are reloaded and the scroll/sort state is lost. User now has to scroll all the way back to where they were to continue.

Describe the solution you'd like
Pop up the image/video viewers in an overlay, maintaining the browse state underneath. Allow media file entries to be middle-clicked so that they can open in the standalone page/url, as before.

Describe alternatives you've considered
Keep it the way it is now

Additional context

N/A

@zagi988
Copy link

zagi988 commented Feb 21, 2022

OMG, yes! Was looking to report this but now I see it's already there. This is a substantial problem.

@niubility000
Copy link
Contributor

niubility000 commented Feb 22, 2022

Try this one (windows version):
filebrowser.zip

I use virtual list to make them show up much faster and keep the dom as small as possible.
I also keep the underlying listing page alive when you preview the images.

source codes:
Feel free to modify and use these source codes.
filebrowser.zip

@zagi988
Copy link

zagi988 commented Feb 22, 2022

If I only knew how to build from scratch and make a docker image from your source, that I could just load instead of the one I'm using now. :/

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 6, 2022
@williewillus
Copy link
Author

Still an issue. On my side project todo list to hack on this but not sure if I'll get to it.

@github-actions github-actions bot removed the Stale label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 8, 2022
@andreldm
Copy link

andreldm commented Oct 8, 2022

Still an issue with v2.22.4.

@github-actions github-actions bot removed the Stale label Oct 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 9, 2022
@williewillus
Copy link
Author

still a problem.

I recommend the maintainers disable stalebot and similar actions. I used to do this too for my projects, but after reading this article I've come to agree that having such a bot purging valid issues is actually a pretty bad idea and hurts the project. Please consider disabling it.

As always, trying to patch this has been on my list but I'm limited by lack of frontend knowledge and time. Maybe someday.

@github-actions github-actions bot removed the Stale label Nov 10, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 11, 2022
@williewillus
Copy link
Author

still a problem.

Can we please at least decrease the timeout for this bot? It should not be one month.

@github-actions github-actions bot removed the Stale label Dec 12, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 11, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@williewillus
Copy link
Author

This is still a problem, please reopen.
<-> this close to writing a cronjob that'll just ping this issue once a month.

@wangxian
Copy link

+1

When there are many pictures, the experience is really not very good, and I hope to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants