Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1849/windowtitle #1850

Merged
merged 7 commits into from
Mar 24, 2022
Merged

Conversation

newhinton
Copy link
Contributor

Description
adds branding to document.title for branding/passwordmanager-use
closes #1849

@newhinton newhinton requested a review from o1egl as a code owner March 5, 2022 21:01
@ramiresviana
Copy link
Contributor

Instead of manipulating the document title on every view, a better approach would be setting the title correctly on the first place. This can be achieved by changing this line:

document.title = to.name;

@newhinton
Copy link
Contributor Author

newhinton commented Mar 16, 2022

@ramiresviana That does not seem to work properly. While you can briefly see the changed name (using document.title = to.name + "TEST";) it gets overriden as soon as the page is finished loading.

If there is a better way to do this i am all ears, but this seemed the most straitforward way to me, especially for the file-view

Edit: it seems to be working partially, but not for the file-view because that overrides its title depending on the path. I will investigate further.

@newhinton
Copy link
Contributor Author

@ramiresviana Thanks for your suggestion!

@newhinton newhinton requested a review from o1egl March 22, 2022 16:22
@o1egl o1egl merged commit f8dfbf7 into filebrowser:master Mar 24, 2022
rahul-r pushed a commit to rahul-r/filebrowser that referenced this pull request Sep 2, 2022
Shada pushed a commit to Shada/filebrowser that referenced this pull request Feb 22, 2023
Shada pushed a commit to Shada/filebrowser that referenced this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add branding.name to window title
3 participants