Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable New File / Folder Buttons when irrelevant. #2125

Closed
WarmChocolateCake opened this issue Sep 8, 2022 · 7 comments
Closed

Disable New File / Folder Buttons when irrelevant. #2125

WarmChocolateCake opened this issue Sep 8, 2022 · 7 comments
Labels

Comments

@WarmChocolateCake
Copy link

Description
Login, navigate to any location.
Click on Settings, click New Folder, Enter a name, Click Create.

Observe "This location can't be reached." page with the path shown as (Root)/ --- even if wasn't in the root location

Click on My Files, navigate to same location, without clicking on Settings, attempt to create the same folder and see that it works correctly.

Expected behaviour
Really, creating Files & Folders isn't a "Settings" activity, so the buttons should be disabled / hidden IMO.

But, if they're intended to still be active, then I would expect a File / Folder to be created in the location I was last in (ie not / )

What is happening instead?
Nothing but an error.

Additional context
Nothing that comes to mind.

How to reproduce?
As per the description above

Files
None

Personally, I think this is just a usability issue. When in Settings, there is no indication of the user's location in the filesystem hierarchy, so having active "New Folder" or "New File" buttons whilst in the settings view is the problem.

Thanks for a great application though! :)

@organizedkaos
Copy link

organizedkaos commented Sep 20, 2022

I have seen this by accident and I agree to having them not visible when in settings menu.

EDIT: I'm not the best coder (still learning) but I managed to fix this issue. When I click in settings now the new file and new folder options are hidden and the my files main button still remains.

ss_main

ss_settings

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@WarmChocolateCake
Copy link
Author

Just to confirm that this is still an issue in 2.22.4 (not that anything said it was going to be fixed in that version... 🙂 )

@github-actions github-actions bot removed the Stale label Oct 26, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 26, 2022
@WarmChocolateCake
Copy link
Author

Maybe this could be marked as Feature Request if it's not being seen as a bug?
Looks like @organizedkaos was able to make a change on their system, so it is "solvable" 🙂

@github-actions github-actions bot removed the Stale label Nov 28, 2022
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 29, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants