Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: video preview click next or prev button subtitles not update … #2423

Merged
merged 2 commits into from
May 1, 2023
Merged

bugfix: video preview click next or prev button subtitles not update … #2423

merged 2 commits into from
May 1, 2023

Conversation

uliian
Copy link
Contributor

@uliian uliian commented Apr 20, 2023

…#2410

Description

🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments

@uliian uliian requested a review from o1egl as a code owner April 20, 2023 03:47
@gedw99
Copy link

gedw99 commented Apr 29, 2023

Oh nice feature !!

Hope this gets in

@o1egl o1egl merged commit 6744cd4 into filebrowser:master May 1, 2023
7 of 8 checks passed
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Jul 31, 2023
@uliian @langren1353
fix: video preview click next or prev button subtitles not update (fi…
9c1b544 
…lebrowser#2423)

(cherry picked from commit 6744cd4)
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Jul 31, 2023
@uliian @langren1353
fix: video preview click next or prev button subtitles not update (fi…
3210a02 
…lebrowser#2423)

(cherry picked from commit 6744cd4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@o1egl o1egl Awaiting requested review from o1egl o1egl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uliian @gedw99 @o1egl