Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solve broken Docker build with alpine image #2486

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

vsalmendra
Copy link
Contributor

Description
Commit b8f35ce excluded docker_config.json by changing .dockerignore rules and this was not reverted by 46d8046. This commit adds the exception back.

Fixes #2484

Testing

 2023-05-31 21:47:50 ⌚  LAPTOP-VA in ~/code/filebrowser/filebrowser
± |fix-docker-build ✓| → docker build . -t test
[+] Building 2.1s (9/9) FINISHED                                                                                                                                                                                                 
 => [internal] load build definition from Dockerfile                                                                                                                                                                        0.0s
 => => transferring dockerfile: 389B                                                                                                                                                                                        0.0s
 => [internal] load .dockerignore                                                                                                                                                                                           0.1s
 => => transferring context: 84B                                                                                                                                                                                            0.0s
 => [internal] load metadata for docker.io/library/alpine:latest                                                                                                                                                            2.0s
 => [1/4] FROM docker.io/library/alpine:latest@sha256:02bb6f428431fbc2809c5d1b41eab5a68350194fb508869a33cb1af4444c9b11                                                                                                      0.0s
 => [internal] load build context                                                                                                                                                                                           0.0s
 => => transferring context: 72B                                                                                                                                                                                            0.0s
 => CACHED [2/4] RUN apk --update add ca-certificates                      mailcap                      curl                                                                                                                0.0s
 => CACHED [3/4] COPY docker_config.json /.filebrowser.json                                                                                                                                                                 0.0s
 => CACHED [4/4] COPY filebrowser /filebrowser                                                                                                                                                                              0.0s
 => exporting to image                                                                                                                                                                                                      0.0s
 => => exporting layers                                                                                                                                                                                                     0.0s
 => => writing image sha256:e8b379024d8b41b8b00fc7e93910f5bce5dd93ca76091c8239efedf81394c3e6                                                                                                                                0.0s
 => => naming to docker.io/library/test  

Commit b8f35ce excluded `docker_config.json` by changing .dockerignore rules
and this was not reverted by 46d8046. This commit adds the exception
back.

Fixes filebrowser#2484
@vsalmendra vsalmendra requested a review from o1egl as a code owner May 31, 2023 19:59
@vsalmendra
Copy link
Contributor Author

Hello @o1egl ! If this fix is of interest, could you approve the workflow execution, so that I can see whether the change had any impact on it? Thanks!

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 5, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this Jul 10, 2023
@o1egl o1egl reopened this Jul 28, 2023
@o1egl o1egl merged commit b8ee340 into filebrowser:master Jul 28, 2023
5 checks passed
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Jul 31, 2023
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build for alpine image not working due to missing json file
2 participants