-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"New Folder" on Move / Create Action Dialogs #2667
Merged
o1egl
merged 11 commits into
filebrowser:master
from
ArthurMousatov:feature-added-create-on-move
Aug 26, 2023
Merged
"New Folder" on Move / Create Action Dialogs #2667
o1egl
merged 11 commits into
filebrowser:master
from
ArthurMousatov:feature-added-create-on-move
Aug 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well done. I think it would be better to align |
I tested both alignments and I personally preferred the offset, but I'll change it! |
It is done, please re-review :) |
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Oct 18, 2023
--------- Co-authored-by: Oleg Lobanov <oleg@lobanov.me> (cherry picked from commit 5994224)
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Oct 18, 2023
--------- Co-authored-by: Oleg Lobanov <oleg@lobanov.me> (cherry picked from commit 5994224)
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Oct 18, 2023
--------- Co-authored-by: Oleg Lobanov <oleg@lobanov.me> (cherry picked from commit 5994224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
Further comments
Le Screenshot:
![image](https://private-user-images.githubusercontent.com/57199800/263057842-3eea8c31-b482-4075-b803-079546481725.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzNDA3ODksIm5iZiI6MTcyMTM0MDQ4OSwicGF0aCI6Ii81NzE5OTgwMC8yNjMwNTc4NDItM2VlYThjMzEtYjQ4Mi00MDc1LWI4MDMtMDc5NTQ2NDgxNzI1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDIyMDgwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyYjcxNjQ3MDY1MWJkMGJmNDY1YjBkMTdiYmYxNGQwMmNmM2U5MmE0YmE0ZGNlMWUzYzhjNmYzY2Q3MTUzYzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qDGAVZMuOYazSv3XXhNdrjkw0QsllmPctsvoyN_rn34)