Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Folder" on Move / Create Action Dialogs #2667

Merged
merged 11 commits into from
Aug 26, 2023

Conversation

ArthurMousatov
Copy link
Contributor

@ArthurMousatov ArthurMousatov commented Aug 24, 2023

Description

  • Added "New Folder" on Move / Create Action Dialogs, as per Add new folder option on copy and move dialog. #2659
  • Due to needing dialog-on-dialog action (move/copy dialog -> new folder dialog -> move/copy dialog), I changed the dialog system to a stack-like implementation
    • No more show/showConfirm/showAction, now its only prompts, which is a list that contains objects with prompt/action/confirm/props values.
    • The new props attribute allows me to pass prop values to dialog components (see FileList.vue:createDir() )
    • Overall, the new dialog system just combines all the related show attributes into one object.
  • Closes Add new folder option on copy and move dialog. #2659

🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • [] AVOID breaking the continuous integration build.

Further comments

Le Screenshot:
image

@o1egl
Copy link
Member

o1egl commented Aug 26, 2023

Well done. I think it would be better to align new folder button with the rest action buttons

@ArthurMousatov
Copy link
Contributor Author

Well done. I think it would be better to align new folder button with the rest action buttons

I tested both alignments and I personally preferred the offset, but I'll change it!

@ArthurMousatov
Copy link
Contributor Author

Well done. I think it would be better to align new folder button with the rest action buttons

It is done, please re-review :)

@o1egl o1egl merged commit 5994224 into filebrowser:master Aug 26, 2023
7 of 8 checks passed
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Oct 18, 2023
---------

Co-authored-by: Oleg Lobanov <oleg@lobanov.me>
(cherry picked from commit 5994224)
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Oct 18, 2023
---------

Co-authored-by: Oleg Lobanov <oleg@lobanov.me>
(cherry picked from commit 5994224)
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Oct 18, 2023
---------

Co-authored-by: Oleg Lobanov <oleg@lobanov.me>
(cherry picked from commit 5994224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new folder option on copy and move dialog.
2 participants