feat: implement upload speed calculation and ETA estimation #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@o1egl thank you! 😄 |
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Oct 18, 2023
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Oct 18, 2023
langren1353
pushed a commit
to langren1353/filebrowser-player
that referenced
this pull request
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have closed the previous pull request(#2675) and reworked on it.
I resolved conflicts regarding the newly merged commits.
Also, I optimized the previously implemented code and addressed several issues.
There has been a significant user demand for transfer speed and ETA for a while.
This Pull Request addresses that need.
Due to the characteristics of the tus protocol, where transfers are made in chunk units, there are frequent starts and stops, leading to a large variance in speed. To address this issue, we have applied a moving average to the speed calculations.
Additionally, to reduce the strain on the threads, the calculations were set to be executed at intervals. Below is a capture of the implementation.