-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2554 configure user session timeout #2753
Conversation
Hi @o1egl, can I get a review/comment on the changes? I fixed the linting issues after the CI failed last time |
Where can I set a custom user session timeout? Is it only through API? |
Is it possible to set TokenExpirationTime in docker? |
Update: I've submitted a PR for this feature. #2845 cfg file should work @StanislavJochman @akamkomputer filebrowser -c your/path/to/filebrowser.json // filebrowser.json
{
"port": 8080,
"baseURL": "",
"address": "127.0.0.1",
"log": "stdout",
"database": "filebrowser.db",
"root": ".",
"tokenExpirationTime": "12h"
} |
But can it be set using dockerfile? Or do I have to edit file manually? |
@StanislavJochman oops, my fault/.. Update: I've submitted a PR for this feature. #2845 # One of the below should work:
filebrowser --token-expiration-time=12h
# or
filebrowser -c fb.json
# fb.json
{
"token-expiration-time": "12h"
} UPDATE: corrected: |
implemented:
not timeout |
What are the allowable values and range here? Can "0" be used to disable the timeout? |
Description
Session timeout is hardcoded to 2 hours. This PR makes that value configurable with a fallback to 2 hours. Related to #2554
There are two use-cases for me for this change. The first is that I wan't to be able to stay logged in for longer. The other one is if I'm downloading really large files and session expires in between then the upload is canceled at that point.
IMO for the second use-case this PR shouldn't be enough and it needs another proper fix.