Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display filesize as base 2 (KiB instead of KB) (Fixes #2744) #2779

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

kloon15
Copy link
Contributor

@kloon15 kloon15 commented Oct 19, 2023

Backport from vue3 branch to display filesizes as KiB/MiB etc.
(Fixes #2744)

馃毃 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

@kloon15 kloon15 requested a review from o1egl as a code owner October 19, 2023 08:53
@o1egl o1egl merged commit cdcd9a3 into filebrowser:master Nov 2, 2023
7 of 8 checks passed
shonge pushed a commit to shonge/filebrowser that referenced this pull request Nov 2, 2023
@kloon15 kloon15 deleted the filesize-kib branch May 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As of v2.25.0, 1KB is calculated and displayed as 1000 bytes instead of 1024 bytes.
2 participants