Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Display Image Resolutions in File Details #2830

Merged
merged 5 commits into from
Nov 25, 2023

Conversation

maeryo
Copy link
Contributor

@maeryo maeryo commented Nov 15, 2023

image

After a long hiatus, I'm excited to submit this pull request. One inconvenience we've often faced is the inability to view the resolution of image files. To address this, I've implemented a feature that allows users to see the resolution of image files when they check the file details.

The supported extensions include:

jpg, jpeg, gif, bmp, png, tif, tiff, webp

Unfortunately, this feature does not extend to video files. Determining the resolution of video files would require the FFmpeg library. Rather than making this decision unilaterally, I believe it's best to seek consensus from project committers and the community before proceeding with such an implementation. However, I'm fully prepared to develop this functionality should there be a demand for it.

I hope this simple yet useful feature enhancement will benefit many users.
Looking forward to your feedback and suggestions.
Thank you!

@maeryo maeryo requested a review from o1egl as a code owner November 15, 2023 14:00
@o1egl o1egl merged commit a09dfa8 into filebrowser:master Nov 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants