Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload progress #993

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Upload progress #993

merged 2 commits into from
Jun 19, 2020

Conversation

ramiresviana
Copy link
Contributor

This new upload progress calculation fixes the following issues:

Non linear progress

  • On a batch of multiples files, the progress bar increases faster when is uploading a small file. The progress should increase linearly, based on size of all files being updated.

Inconsistently progress #990

  • Every time user uploads a file, a new calculation is made based on the current batch of files, ignoring files that was being uploaded before. Calculation should be done with information of all files being upload.

Performance

  • Events from files being uploaded can be heavily expensive, every upload will trigger multiple events every second. Using throttle is possible to limit the execution of some functions.

@o1egl o1egl merged commit cd454ba into filebrowser:master Jun 19, 2020
@o1egl o1egl mentioned this pull request Jun 19, 2020
monkeyWie pushed a commit to monkeyWie/filebrowser that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants